No, you're right. Luke didn't accomplish anything.
Like Holdo, he doesn't even tell the rebels his plan. He just shows up and goes out into the field. In fact, it's so poorly written that they have Poe come out of nowehere and explain Luke's intention to everyone. Other than lazy writing, how did Poe even guess that?
It's not even a long distraction. I mean, Finn and Rose were miles away from the bunker right near the AT-ATs and mini Death Star battering ram canon (lol, gotta get those Death Stars in there) and Finn was able to drag Rose all the way back to the base, unharmed.
If Luke didn't show up, they all had plenty of time to follow the stupid Crystal foxes to the those rocks where Rey would have found them anyway.
Luke died for nothing. That's not even the most ridiculous part. He wasn't even really there and he STILL died! It's the most pathetic and poorly thought out death since Padme croaking on the hospital bed. Instead of medical pregnancy droids "boo baaaahing" around him, Luke had ****ing Porgs chirping. It's frustrating and ridiculous.
Like Han's, it's so unceremonious too. They're not even heroic deaths. They just sacrifice themselves for absolutely nothing other than to be disposed of so the torch can be passed off to the new characters.